Skip to content

ECHO-743 fix dembrane with uppercase 'D' in chat, report, ECHO #547

Merged
ussaama merged 1 commit into
mainfrom
fix/dembrane-lowercase-in-templates
Apr 21, 2026
Merged

ECHO-743 fix dembrane with uppercase 'D' in chat, report, ECHO #547
ussaama merged 1 commit into
mainfrom
fix/dembrane-lowercase-in-templates

Conversation

@ussaama
Copy link
Copy Markdown
Contributor

@ussaama ussaama commented Apr 21, 2026

Summary by CodeRabbit

  • Style
    • Platform branding standardized: all platform name references now consistently display as lowercase "dembrane" across chat responses, reports, usage analytics, and system prompts in all supported languages.

…emplates and documentation. Update system prompts to ensure consistent branding and improve clarity in user instructions.
@linear
Copy link
Copy Markdown

linear Bot commented Apr 21, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Walkthrough

The PR standardizes platform branding across the codebase by updating "Dembrane Echo" references to lowercase "dembrane" in system prompts, templates, and user-facing text, with explicit style guardrails enforcing consistent lowercase capitalization regardless of sentence position.

Changes

Cohort / File(s) Summary
Agent System Prompt
echo/agent/agent.py
Updated system prompt branding from "Dembrane Echo" to "dembrane" with explicit guardrail enforcing lowercase styling even at sentence starts.
Multilingual Reply System Templates
echo/server/prompt_templates/get_reply_system.{de,en,es,fr,it,nl,uk}.jinja
Added formatting instructions across all language variants requiring platform name to be written as "dembrane" in lowercase, including at sentence beginnings.
Multilingual Chat System Templates
echo/server/prompt_templates/system_chat.{de,en,es,fr,it,nl,uk}.jinja
Added explicit "DO NOT" constraints in both overview and context-specific branches across all languages forbidding capitalized "Dembrane" in favor of lowercase "dembrane".
Multilingual Report Templates
echo/server/prompt_templates/system_report.{de,en,es,fr,it,nl,uk}.jinja
Added formatting requirements across all language variants mandating lowercase "dembrane" for platform name references, including sentence-initial positions.
Additional Prompt Templates
echo/server/prompt_templates/generate_artifact.en.jinja, suggestions_system.en.jinja
Added platform name lowercase formatting guidelines to generation and suggestion templates.
Usage Tracker Files
echo/tools/usage-tracker/src/usage_tracker/pdf_export.py, prompts/__init__.py, prompts/insights_system.j2
Updated PDF report title and platform context header from "Dembrane Echo" branding to lowercase "dembrane" styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

improvement


LGTM 🔥 Solid branding consistency pass across the board. The repetitive pattern (same lowercase guardrail applied systematically across 16+ language variants) keeps complexity down nicely.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: standardizing 'dembrane' to lowercase across templates and related files, which is the primary focus of the changeset across 27 files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dembrane-lowercase-in-templates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
echo/tools/usage-tracker/src/usage_tracker/pdf_export.py (1)

1012-1012: ⚠️ Potential issue | 🟡 Minor

Update footer casing to match brand style.

Line 1012 uses "ECHO Usage Tracker" but the title above (line 450) is "dembrane Usage Report". Per STYLE_GUIDE.md, "dembrane" is always lowercase. Change footer to "dembrane Usage Tracker" for consistency.

Current line 1012
f"Generated by ECHO Usage Tracker · {date.today().strftime('%Y-%m-%d')}",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@echo/tools/usage-tracker/src/usage_tracker/pdf_export.py` at line 1012,
Update the footer string in pdf_export.py that currently reads f"Generated by
ECHO Usage Tracker · {date.today().strftime('%Y-%m-%d')}" to use the brand's
lowercase name; replace "ECHO Usage Tracker" with "dembrane Usage Tracker" (keep
the existing f-string and date formatting intact) so the footer matches the
title/casing used elsewhere.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@echo/server/prompt_templates/system_report.de.jinja`:
- Line 62: The German template contains mismatched curly quotes around the brand
occurrences `„dembrane"` and `„Dembrane"`; update those instances in
system_report.de.jinja to use matching German quotation marks (`„dembrane“` /
`„Dembrane“`) or switch both to straight ASCII quotes (`"dembrane"` /
`"Dembrane"`) to match the other language templates and keep punctuation
consistent across the file.

---

Outside diff comments:
In `@echo/tools/usage-tracker/src/usage_tracker/pdf_export.py`:
- Line 1012: Update the footer string in pdf_export.py that currently reads
f"Generated by ECHO Usage Tracker · {date.today().strftime('%Y-%m-%d')}" to use
the brand's lowercase name; replace "ECHO Usage Tracker" with "dembrane Usage
Tracker" (keep the existing f-string and date formatting intact) so the footer
matches the title/casing used elsewhere.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 21c60026-6ad0-49ee-ae54-7c9f44376abc

📥 Commits

Reviewing files that changed from the base of the PR and between d612e19 and 33db524.

📒 Files selected for processing (27)
  • echo/agent/agent.py
  • echo/server/prompt_templates/generate_artifact.en.jinja
  • echo/server/prompt_templates/get_reply_system.de.jinja
  • echo/server/prompt_templates/get_reply_system.en.jinja
  • echo/server/prompt_templates/get_reply_system.es.jinja
  • echo/server/prompt_templates/get_reply_system.fr.jinja
  • echo/server/prompt_templates/get_reply_system.it.jinja
  • echo/server/prompt_templates/get_reply_system.nl.jinja
  • echo/server/prompt_templates/get_reply_system.uk.jinja
  • echo/server/prompt_templates/suggestions_system.en.jinja
  • echo/server/prompt_templates/system_chat.de.jinja
  • echo/server/prompt_templates/system_chat.en.jinja
  • echo/server/prompt_templates/system_chat.es.jinja
  • echo/server/prompt_templates/system_chat.fr.jinja
  • echo/server/prompt_templates/system_chat.it.jinja
  • echo/server/prompt_templates/system_chat.nl.jinja
  • echo/server/prompt_templates/system_chat.uk.jinja
  • echo/server/prompt_templates/system_report.de.jinja
  • echo/server/prompt_templates/system_report.en.jinja
  • echo/server/prompt_templates/system_report.es.jinja
  • echo/server/prompt_templates/system_report.fr.jinja
  • echo/server/prompt_templates/system_report.it.jinja
  • echo/server/prompt_templates/system_report.nl.jinja
  • echo/server/prompt_templates/system_report.uk.jinja
  • echo/tools/usage-tracker/src/usage_tracker/pdf_export.py
  • echo/tools/usage-tracker/src/usage_tracker/prompts/__init__.py
  • echo/tools/usage-tracker/src/usage_tracker/prompts/insights_system.j2


Behalten Sie während des gesamten Artikels einen professionellen, journalistischen Ton bei. Die Sprache sollte klar, präzise und für ein allgemeines Publikum leicht verständlich sein. Vermeiden Sie umgangssprachliche Ausdrücke, Fachjargon oder übermäßig technische Begriffe, es sei denn, sie sind wesentlich und werden erklärt.

Wenn Sie auf die Plattform namentlich verweisen, schreiben Sie immer „dembrane" in Kleinbuchstaben, auch am Satzanfang. Schreiben Sie es nie als „Dembrane".
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Nit: curly-quote mismatch around the brand name.

Using German opening with ASCII closing " — e.g. „dembrane" and „Dembrane". Should be „dembrane" / „Dembrane" (or just stick to straight "..." like the English/ES/NL siblings) for consistency. Harmless to the LLM, but the template reads cleaner with matched quotes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@echo/server/prompt_templates/system_report.de.jinja` at line 62, The German
template contains mismatched curly quotes around the brand occurrences
`„dembrane"` and `„Dembrane"`; update those instances in system_report.de.jinja
to use matching German quotation marks (`„dembrane“` / `„Dembrane“`) or switch
both to straight ASCII quotes (`"dembrane"` / `"Dembrane"`) to match the other
language templates and keep punctuation consistent across the file.

@ussaama ussaama requested a review from spashii April 21, 2026 12:21
@ussaama ussaama added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 649e802 Apr 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants