docs(agents): ban variant="default", color="blue", and em dashes#589
Conversation
Agents kept reaching for off-brand Mantine defaults (variant="default",
color="blue") and sprinkling em dashes into UI copy, partly because the
AGENTS.md files themselves modeled em-dash style and never spelled out the
Button rules in code terms.
- Add a Buttons and colors section to AGENTS.md and frontend/AGENTS.md
with concrete do/don't snippets: the theme already defaults to
color="primary" + variant="filled", so most buttons need no props.
Allowed variants: omit, outline, subtle (light only as a last resort).
Never variant="default", never color="blue".
- Add a "no em dashes" rule under Brand & UI Copy, applied to both
user-facing copy and the agent docs themselves.
- Strip em dashes from AGENTS.md, frontend/AGENTS.md, server/AGENTS.md
so the docs stop modeling the style they're meant to forbid.
WalkthroughThree agent operating instruction documents are updated to standardize punctuation and phrasing, refine Directus workflows, introduce frontend styling constraints, and clarify server-side patterns. Changes are primarily documentation style improvements with targeted content additions for Directus, frontend color rules, and server reconciliation behavior. ChangesCore Agent Operating Instructions Refinement
Frontend Agent Guidance Enhancements
Server Agent Guidance Refinements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@echo/AGENTS.md`:
- Around line 55-65: The Button/color guidance in echo/AGENTS.md is duplicated
from frontend/AGENTS.md; replace the full rules block under the "Buttons and
colors" heading with a short pointer to frontend/AGENTS.md and a TL;DR note
(e.g., reference that mantine defaults apply and "never use variant='default' or
color='blue'") so the authoritative rules live in frontend/AGENTS.md and this
root doc only links to it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c4e4ffa8-d528-4f3a-984e-105db2b36bb1
📒 Files selected for processing (3)
echo/AGENTS.mdecho/frontend/AGENTS.mdecho/server/AGENTS.md
dembrane-sam-bot
left a comment
There was a problem hiding this comment.
Reviewed PR #589. Clean and valuable documentation hygiene.
Key updates:
- Style constraints: Added rules banning em dashes (—) in user-facing copy and within agent docs to prevent AI models from copying and propagating them.
- Mantine Buttons & colors: Defined explicit rules in root
AGENTS.mdandfrontend/AGENTS.mdto prevent off-brand styling (banningvariant="default"andcolor="blue"in favor of theme-defaultcolor="primary"/ Royal Blue). - Em-dash cleanup: Stripped all existing em dashes from
AGENTS.md,frontend/AGENTS.md, andserver/AGENTS.mdso the docs stop modeling the style they forbid.
CI checks are green. Since my operational limits forbid me from approving PRs directly on GitHub (humans approve), I am submitting this as a comment review. Sameer can go ahead and approve/merge.
Confidence: high
Agents kept reaching for off-brand Mantine defaults (variant="default",
color="blue") and sprinkling em dashes into UI copy, partly because the
AGENTS.md files themselves modeled em-dash style and never spelled out the
Button rules in code terms.
Summary by CodeRabbit