refactor(frontend): streamline breadcrumbs and top-level hierarchy views to 'Overview'#594
Conversation
…ews to 'Overview'
|
Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
|
Warning Review limit reached
More reviews will be available in 2 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughPR consolidates navigation labeling and breadcrumb visibility across the app. Breadcrumb logic now returns trails for user-home and workspace-home views, handles single-crumb rendering, and provides context-aware labels. Sidebar components uniformly rename "Home" to "Overview" and swap icon from ChangesOverview label and breadcrumb unification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
echo/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsx (1)
65-66: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winStale behavior comment should be updated.
Line 65 says breadcrumbs render only for 2+ crumbs, but Line 214 now renders whenever there is at least 1 crumb. Please align the comment with current behavior to avoid future regressions.
Also applies to: 214-214
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@echo/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsx` around lines 65 - 66, Update the stale comment in the AppBreadcrumbs component: change the “Brand: 'Breadcrumbs for deep nesting only'. Render only when there are 2+ meaningful crumbs to show.” remark to reflect the current behavior (breadcrumbs render when there is at least 1 meaningful crumb). Locate the comment inside the AppBreadcrumbs.tsx file near the top of the component (the existing “Brand: ...” comment) and revise it to accurately describe the one-or-more crumb rendering condition used by the render logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@echo/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsx`:
- Around line 147-154: The breadcrumb logic in AppBreadcrumbs.tsx incorrectly
short-circuits on (section === "home" || !section), preventing the /projects/new
branch from ever running; update the branching order so the pathname check runs
first: check if window.location.pathname.endsWith("/projects/new") and push({
label: "New project" }) before the (section === "home" || !section) fallback
that pushes({ label: "Overview" }); keep references to the same variables
(section, window.location.pathname) and the same push calls (out.push) when
implementing the reordering.
---
Outside diff comments:
In `@echo/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsx`:
- Around line 65-66: Update the stale comment in the AppBreadcrumbs component:
change the “Brand: 'Breadcrumbs for deep nesting only'. Render only when there
are 2+ meaningful crumbs to show.” remark to reflect the current behavior
(breadcrumbs render when there is at least 1 meaningful crumb). Locate the
comment inside the AppBreadcrumbs.tsx file near the top of the component (the
existing “Brand: ...” comment) and revise it to accurately describe the
one-or-more crumb rendering condition used by the render logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3b7814bd-92a3-4bed-998f-0fa54722eaf8
📒 Files selected for processing (5)
echo/frontend/src/components/layout/ProjectOverviewLayout.tsxecho/frontend/src/features/sidebar/breadcrumbs/AppBreadcrumbs.tsxecho/frontend/src/features/sidebar/views/org/OrgHomeView.tsxecho/frontend/src/features/sidebar/views/project/ProjectHomeView.tsxecho/frontend/src/features/sidebar/views/workspace/WorkspaceHomeView.tsx
… in breadcrumbs - Updates comment in AppBreadcrumbs to reflect current breadcrumb rendering behavior (1+ crumb) - Reorders workspace-home breadcrumb checks so pathname check runs first, preventing wrong short-circuit - Fixes useCollapsedElseIf biome lint warning by using flat else-if formatting Refs: #594
2 participants
What this changes
AppWindow(was:House) — OrgHomeView.tsx, WorkspaceHomeView.tsx, ProjectHomeView.tsxConfidence
Confidence: high. Pure frontend UI & routing logic changes, highly focused on aligning breadcrumb and sidebar presentation. No functional APIs, DB queries, or schema changes are touched.
Summary by CodeRabbit
Bug Fixes
UI/UX Updates