chore(imports): drop the java.awt.* / java.util.* co-wildcard in four files#192
Merged
Conversation
… files InvoiceTemplateComposer, ProposalTemplateComposer, WeeklyScheduleTemplateComposer, and the engine PdfRenderingSystemECS imported both java.awt.* and java.util.*, leaving List resolvable from either java.awt.List or java.util.List — sound today only because java.awt.List was never referenced. Each uses only java.awt.Color, so the awt wildcard becomes an explicit import java.awt.Color. No behaviour change; full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four files imported both
java.awt.*andjava.util.*, which leavesListresolvable from eitherjava.awt.Listorjava.util.List— it compiles today only becausejava.awt.Listis never referenced, but a futurejava.awtreference would turn it into an ambiguous-import break.Each file uses only
java.awt.Colorfrom the awt wildcard (Strokeis explicitly imported fromcom.demcha.compose.engine.components.content.shape, andListis already explicitly imported asjava.util.List), so the wildcard becomes an explicitimport java.awt.Color;:InvoiceTemplateComposerProposalTemplateComposerWeeklyScheduleTemplateComposerPdfRenderingSystemECS(engine renderer)No behaviour change — import-only. Full suite 1378 green. Scoped deliberately to the awt/util ambiguity; the broader
style.*/node.*wildcard convention introduced by the v1.8 sweep is left as-is.Lane: hygiene (templates + engine imports).