feat(cv-v2): Mint Editorial colour Options + banded masthead + parity baselines#78
Merged
Conversation
MintEditorial and MintEditorialLetter gain an Options colour API (accentColor, ruleColor, nameColor, headerBandColor) whose defaults reproduce the stock render exactly. headerBandColor paints a full-page-width header band from the top page edge down to the masthead rule, drawn page-1 only via a CanvasLayerNode so it costs no flow height and the CV stays two pages. The masthead-band geometry is pinned to measured constants, now guarded by smoke tests asserting the default masthead position and the banded-vs-bandless footprint stay in sync.
Registers mint_editorial and mint-editorial-letter in the CV and cover-letter visual parity suites with committed page baselines, documents the SkillBar and IconTextRow widgets in the v2 authoring catalog, and adds the Mint Editorial entry to the v1.6.5 CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the colour-customisation Options API and the banded masthead to the Mint Editorial CV preset + its paired cover letter, and registers both in the visual parity suites with committed baselines. Builds on the already-merged Mint base (#77).
What's in
MintEditorial.Options/MintEditorialLetter.Options):accentColor,ruleColor,nameColor,headerBandColor— defaults reproduce the stock render exactly.headerBandColorpaints a full-page-width header band from the top page edge down to the masthead rule, drawn page-1-only via aCanvasLayerNodeso it costs no flow height (the CV stays two pages). The band geometry is pinned to measured constants, guarded by smoke tests asserting the default masthead position and the banded-vs-bandless footprint stay in sync.mint_editorial(CV, 2 pages) +mint-editorial-letterregistered inCvV2VisualParityTest/CoverLetterV2VisualParityTestwith committed page baselines.SkillBar+IconTextRowadded to the v2 widget catalog; Mint Editorial entry under v1.6.5.Test plan
mvnw clean verify -pl .— 980 tests, 0 failures (doclint on the new public Options API passes)