chore(build): scope byte-buddy as test (PR-7.2)#79
Merged
Conversation
…d POM Mockito already excludes its transitive byte-buddy and we pin a single version in a standalone dependency; that dependency was missing a scope, so the published POM advertised byte-buddy as a compile dependency even though no production code references it. Setting <scope>test</scope> keeps the version pin while keeping byte-buddy off consumers' runtime classpath; mvn dependency:tree now shows both byte-buddy and byte-buddy-agent only with :test. Part of v1.6.5 publish hygiene (PR-7.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<scope>test</scope>on the standalonebyte-buddydependency in pom.xml.v1.6.5 — PlannedCHANGELOG entry documenting the publish-hygiene fix.Why
byte-buddyis used only by Mockito at test time. Mockito alreadyexcludes its transitive
byte-buddy(so the project can pin a singleversion) but the standalone pinning dependency was missing a scope —
the published POM therefore advertised
byte-buddyas a compiledependency even though no production code references it.
With
<scope>test</scope>the version pin stays, but consumers nolonger inherit
byte-buddyon their runtime classpath.This is the second of three PRs unblocking the v1.6.5 cut (after
PR-7.1
ci/exec-plugin-drift-fixand before PR-7.3fix/pagebackgrounds-empty-and-row-weights). Tracked in the privaterelease-readiness taskboard.
Verification
./mvnw -pl . dependency:tree— bothnet.bytebuddy:byte-buddy:jar:1.18.8and the transitivebyte-buddy-agent:jar:1.17.7now show:testonly; no runtime branch references either../mvnw test -pl .— 1016 tests, 0 failures, 0 errors (~54 s).Test plan
dependency:treeshows no runtimebyte-buddy