Merged
Conversation
I've left the advance voting information in the fixtures for now to verify the code does what we want.
GeoWill
commented
Mar 19, 2026
| + `date` | ||
| + `open` | ||
| + `close` | ||
| + `advance_voting_station`: (object, nullable) - Deprecated. Always null. |
Contributor
Author
There was a problem hiding this comment.
Do we want to document it's existence? I thought 'yes', but don't mind. This follows what we did with custom finder.
GeoWill
commented
Mar 19, 2026
| Errors will be reported using HTTP status codes. The body of the error will be formatted as valid JSON and will give a description of the error | ||
| </p></div><div class="ds-stack-smaller"><figure><figcaption> | ||
| Example error response</figcaption><pre>{ "detail": "Could not geocode from any source" }</pre></figure></div></div></div></div> | ||
| <code>cancelled</code> boolean:</p><ul><li><p><code>NO_CANDIDATES</code>: No candidates</p></li><li><p><code>EQUAL_CANDIDATES</code>: Equal candidates to contested seats</p></li><li><p><code>UNDER_CONTESTED</code>: Fewer candidates than seats</p></li><li><p><code>CANDIDATE_DEATH</code>: Death of a candidate</p></li></ul><h3>Previous Party Affiliations</h3><p>The <a href="https://www.legislation.gov.uk/wsi/2021/1459/made">Local Elections (Principal Areas) (Wales) Rules 2021</a> Statutory |
Contributor
Author
There was a problem hiding this comment.
This diff is horrendous. But essentially This new line (2726) contains some of old line 2856 and some of oldline 2884 smooshed together.
It's currently deployed to dev so docs are visible at https://developers.environments.womblelabs.co.uk/api/v1/
GeoWill
commented
Mar 19, 2026
| + postcode: (string) - Postcode for this polling station | ||
| + address: `Earlswood Social Club, 160-164 Greenway Road, Rumney` (string) - Address for this polling station | ||
| + `advance_voting_station`: (object, nullable) - Deprecated. Always null. | ||
| + `advance_voting_station`: (object, nullable) - Deprecated field. This will always be null. |
Contributor
Author
There was a problem hiding this comment.
use same text as custom finder
Member
|
Yeah I think it is good to document that it is there, same as |
chris48s
approved these changes
Mar 25, 2026
GeoWill
force-pushed
the
deprecate-advance-voting-stations
branch
from
428fc77 to
d9eaac1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.