playeffect - support new data types#2678
Merged
mcmonkey4eva merged 12 commits intoJan 23, 2025
Merged
Conversation
mcmonkey4eva
reviewed
Dec 2, 2024
| // - For TARGET_COLOR, the input is of format: <color>|<location>, for example "red|<player.cursor_on>". Color input is any valid ColorTag object. | ||
| // - For COLOR, the input is any valid ColorTag. | ||
| // - For FLOAT, the input is any valid ElementTag(Decimal). | ||
| // - For INTEGER, the input is any valid ElementTag(Integer). |
Member
There was a problem hiding this comment.
it'd be (Number) but also just say any valid number, don't be overly technical when you don't need to be
Also what the heck is an integer particle? That For x y z particles, half should name particles that use a format, not the format's java class name
mcmonkey4eva
reviewed
Dec 3, 2024
| if (dataList.size() != 2) { | ||
| Debug.echoError("TargetColor special_data must have 2 list entries for particle: " + particleEffect.name()); | ||
| return; | ||
| } else { |
mcmonkey4eva
previously approved these changes
Dec 3, 2024
mcmonkey4eva
previously approved these changes
Dec 27, 2024
mcmonkey4eva
previously approved these changes
Jan 5, 2025
tal5
reviewed
Jan 8, 2025
Member
tal5
left a comment
tal5
left a comment
There was a problem hiding this comment.
LGTM, but should change the command syntax text to specify special_data is a map now I believe
Member
|
Other then that small comment ^, this has some merge conflicts that need to be resolved (which, feel free to ask on Discord if you need any help with that) |
tal5
approved these changes
Jan 23, 2025
mcmonkey4eva
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new DataTypes for particles. Support for TRAIL and TARGET_COLOR particle types were requested on Discord. It also adds support for special SHRIEKER and SCULK particles.
https://discord.com/channels/315163488085475337/1310336968399257610/1310336968399257610
https://discord.com/channels/315163488085475337/1301846255365783614/1301846255365783614