Updated Variant property to include chickens, cows, and pigs for 1.21+#2717
Merged
tal5 merged 3 commits intoDenizenScript:devfrom May 8, 2025
Merged
Updated Variant property to include chickens, cows, and pigs for 1.21+#2717tal5 merged 3 commits intoDenizenScript:devfrom
tal5 merged 3 commits intoDenizenScript:devfrom
Conversation
mcmonkey4eva
previously approved these changes
Apr 10, 2025
tal5
requested changes
Apr 13, 2025
| public ElementTag getPropertyValue() { | ||
| return new ElementTag(Utilities.namespacedKeyToString(as(Wolf.class).getVariant().getKey())); | ||
| if (getEntity() instanceof Wolf wolf) { | ||
| return new ElementTag(Utilities.namespacedKeyToString(wolf.getVariant().getKeyOrThrow())); |
Member
There was a problem hiding this comment.
Did Wolf.Variant#getKeyOrThrow exist on 1.20.6?
Member
There was a problem hiding this comment.
Actually, pretty sure you can't use that either way - Paper doesn't have these Spigot changes
tal5
requested changes
May 3, 2025
Comment on lines
+52
to
+58
| Wolf.Variant entityVariety = Utilities.elementToEnumlike(variant, Wolf.Variant.class); | ||
| if (entityVariety != null) { | ||
| wolf.setVariant(entityVariety); | ||
| } | ||
| else { | ||
| mechanism.echoError("Invalid wolf variant specified: " + variant); | ||
| } |
Member
There was a problem hiding this comment.
Can use the new 01a7819 here.
Also for the naming, generally you'd name it after the object type, so Variant instead Variety and probably wolf instead of entity - wolfVariant.
| return new ElementTag(Utilities.namespacedKeyToString(wolf.getVariant().getKey())); | ||
| } | ||
| else if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21) && getEntity() instanceof Chicken chicken) { | ||
| return new ElementTag(Utilities.namespacedKeyToString(chicken.getVariant().getKey())); |
mcmonkey4eva
approved these changes
May 4, 2025
tal5
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.