1.21.5 Bungee chat fixes#2718
Merged
tal5 merged 5 commits intoDenizenScript:devfrom Apr 16, 2025
Merged
Conversation
This reverts commit 7f9f2c8.
mcmonkey4eva
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned out to be a bunch of stuff in one PR, but will try splitting the commits and description at least.
NMSHandler#getVersioncalls before initializationNeeded to check the version in
FormattedTextHelper's initialization (beforeNMSHandler), so the version is now checked and stored in astaticblock so that it's accessible at all times.Component JSON parsing
ComponentSerializer#parsecan no longer be used, as that usesVersionedComponentSerializer#getDefaultwhich returns the 1.16 serializer.FormattedTextHelper#parseJsonwhich checks the version and runs it though the proper serializer.Base
vanillaStyleSpigotComponentGSONoff of default Bungee serializerFormattedTextHelper#getBungeeGson, which returns the BungeeGsoninstance.vanillaStyleSpigotComponentGSONnow usesgetBungeeGson+Gson#newBuilderto#disableHtmlEscapingwithout having to redefine the entire serializer.Fixes to
HoverFormatHelper's workaroundHoverFormatHelper#tryInitializeItemHoverFixis now called right beforeFormattedTextHelper.vanillaStyleSpigotComponentGSONis initialized, so that it contains the item hover workarounds.tryInitializeItemHoverFixnow usesFormattedTextHelper#getBungeeGson.tryInitializeItemHoverFixnow has different reflection logic for setting aVersionComponentSerializervsComponentSerializer.