EntityBeeStingers property creation#2724
Merged
mcmonkey4eva merged 4 commits intoDenizenScript:devfrom May 4, 2025
Merged
Conversation
mcmonkey4eva
reviewed
May 3, 2025
|
|
||
| // <--[property] | ||
| // @object EntityTag | ||
| // @name body_stingers |
Member
There was a problem hiding this comment.
is it BeeStingers or body_stingers? These should align (body_stingers is probably the right one)
mcmonkey4eva
reviewed
May 3, 2025
| @Override | ||
| public ElementTag getPropertyValue() { | ||
| int stingers = getLivingEntity().getBeeStingersInBody(); | ||
| return stingers == 0 ? null : new ElementTag(stingers); |
Member
There was a problem hiding this comment.
should use the isdefault method, otherwise the tag will be null here, which wouldn't be great
mcmonkey4eva
reviewed
May 3, 2025
| @Override | ||
| public ElementTag getPropertyValue() { | ||
| int stingers = getLivingEntity().getBeeStingersInBody(); | ||
| return stingers == 0 ? null : new ElementTag(stingers); |
Member
There was a problem hiding this comment.
this null shouldn't be here still
tal5
approved these changes
May 4, 2025
mcmonkey4eva
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in https://discord.com/channels/315163488085475337/1365704050443685958