Fix for Cow -> AbstractCow bytecode remap#2727
Merged
mcmonkey4eva merged 3 commits intoDenizenScript:devfrom May 22, 2025
Merged
Fix for Cow -> AbstractCow bytecode remap#2727mcmonkey4eva merged 3 commits intoDenizenScript:devfrom
Cow -> AbstractCow bytecode remap#2727mcmonkey4eva merged 3 commits intoDenizenScript:devfrom
Conversation
mcmonkey4eva
approved these changes
May 22, 2025
SNWCreations
added a commit
to SNWCreations/Citizens2
that referenced
this pull request
Jun 7, 2025
Thanks to @MC-Samuel for referencing to the way of fixing it. Reference: https://discord.com/channels/315163488085475337/1380252795701301308/1380767310658146454 DenizenScript/Denizen#2727
fullwall
pushed a commit
to CitizensDev/Citizens2
that referenced
this pull request
Jun 7, 2025
…map (#3249) * fix: set cow variant by using MethodHandle because of bad bytecode remap Thanks to @MC-Samuel for referencing to the way of fixing it. Reference: https://discord.com/channels/315163488085475337/1380252795701301308/1380767310658146454 DenizenScript/Denizen#2727 * chore: remove unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://discord.com/channels/315163488085475337/1359093430533226586/1374101228211929263.
Needs DenizenScript/Denizen-Core#112
Cowacted asAbstractCowon old versions (I.e. other cow variants extended it), so plugins with an older API version getCowremapped to the newAbstractCowfor stuff likeinstanceofchecks and whatnot to work as they used to - since we can't bump the API version obviously, this works around it with reflection.