Merged
Conversation
tal5
requested changes
Jan 27, 2026
| // TODO: 1.21.5: TransmuteRecipe? | ||
| /* | ||
| SmithingTransformRecipe recipe = new SmithingTransformRecipe(Optional.of(templateItemRecipe), baseItemRecipe, Optional.of(upgradeItemRecipe), CraftItemStack.asNMSCopy(result)); | ||
| SmithingTransformRecipe recipe = new SmithingTransformRecipe(Optional.ofNullable(templateItemRecipe), baseItemRecipe, Optional.of(upgradeItemRecipe), new TransmuteResult(CraftItemStack.asNMSCopy(result).getItem())); |
Member
There was a problem hiding this comment.
You'd need to pass in more data to the TransmuteResult here, can put the NMS ItemStack in a variable and then get the item type (like it does rn), count of the stack, and the components patch via #getComponentsPatch (iirc).
tal5
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the smithing recipes on version 1.21.
Related discussion at https://discord.com/channels/315163488085475337/1461012887798677504
Reported in https://discord.com/channels/315163488085475337/1350649389135302748 and https://discord.com/channels/315163488085475337/1364732929644826735