Skip to content

Fix overlapping clicks with popup menu#21

Merged
DennisLent merged 1 commit intomainfrom
codex/fix-overlapping-airport/plane-clicks-with-popup
Aug 4, 2025
Merged

Fix overlapping clicks with popup menu#21
DennisLent merged 1 commit intomainfrom
codex/fix-overlapping-airport/plane-clicks-with-popup

Conversation

@DennisLent
Copy link
Copy Markdown
Owner

Summary

  • add ClickItem enum and overlap menu state to GUI
  • detect overlapping airport and plane clicks, opening a popup menu when needed
  • add helper for processing click items with unit tests

Testing

  • cargo test
  • cargo test -p rusty_runways_gui

https://chatgpt.com/codex/tasks/task_e_68907eca2100832088869b2b1eb426a6

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 8.65385% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.74%. Comparing base (7d0464f) to head (06f8e24).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/gui/src/gui.rs 8.65% 95 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   34.35%   34.74%   +0.38%     
==========================================
  Files          21       21              
  Lines        1240     1278      +38     
==========================================
+ Hits          426      444      +18     
- Misses        814      834      +20     
Flag Coverage Δ
rust 34.74% <8.65%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DennisLent DennisLent merged commit 9df0726 into main Aug 4, 2025
3 of 4 checks passed
@DennisLent DennisLent deleted the codex/fix-overlapping-airport/plane-clicks-with-popup branch August 4, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant