Skip to content

Conversation

@fundthmcalculus
Copy link
Contributor

  • Typescript is a known protoc-gen-sdk issue of updating the imports
  • Golang was a miss in the python line replace.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Base: 15.42% // Head: 16.46% // Increases project coverage by +1.04% 🎉

Coverage data is based on head (82790cc) compared to base (ba95e91).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1073      +/-   ##
============================================
+ Coverage     15.42%   16.46%   +1.04%     
  Complexity      909      909              
============================================
  Files           263      294      +31     
  Lines         45157    46737    +1580     
  Branches       4944     4944              
============================================
+ Hits           6964     7694     +730     
- Misses        37553    38320     +767     
- Partials        640      723      +83     
Impacted Files Coverage Δ
dotnet/Trinsic/CredentialService.cs 44.11% <0.00%> (ø)
go/services/trustregistry_service.go 32.18% <0.00%> (ø)
dotnet/Trinsic/WalletService.cs 36.36% <0.00%> (ø)
dotnet/Trinsic/AccountService.cs 47.69% <0.00%> (ø)
.../Trinsic/Extensions/ServiceCollectionExtensions.cs 100.00% <0.00%> (ø)
go/services/services.go 78.65% <0.00%> (ø)
go/services/token_provider.go 30.76% <0.00%> (ø)
go/services/template_service.go 26.22% <0.00%> (ø)
dotnet/Trinsic/Storage/FileTokenProvider.cs 22.22% <0.00%> (ø)
go/services/provider_service.go 23.67% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@geel9 geel9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fundthmcalculus fundthmcalculus merged commit 9b97049 into main Sep 20, 2022
@fundthmcalculus fundthmcalculus deleted the server-copied-protos-import-fix branch September 20, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants