Skip to content

Update to Golang SDK #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2022
Merged

Update to Golang SDK #478

merged 4 commits into from
Mar 10, 2022

Conversation

@sethjback
Copy link
Contributor

@sethjback sethjback commented Mar 10, 2022

Closes #474

  • Makes base implementations of the interfaces private
  • Comments interface definitions
  • Consistent use of sdk service request objects across calls
  • Service constructors use Options struct that wraps ServiceOptions and the grpc client connection to allow connection sharing between clients

@sethjback sethjback requested a review from tmarkovski March 10, 2022 18:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2022 •
edited
Loading

Golang Test Report

  2 files  ±0    2 suites  ±0   7s ⏱️ -1s
12 tests ±0    7 ✔️ ±0  0 💤 ±0    5 ❌ ±0 
24 runs  ±0  14 ✔️ ±0  0 💤 ±0  10 ❌ ±0 

For more details on these failures, see this check.

Results for commit c7aec52. ± Comparison against base commit 3b695b9.

♻️ This comment has been updated with latest results.

@tmarkovski tmarkovski added this to the 2022 Q1 milestone Mar 10, 2022
fundthmcalculus
fundthmcalculus approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@fundthmcalculus fundthmcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sethjback sethjback merged commit 5d4cae9 into main Mar 10, 2022
@sethjback sethjback deleted the feat-golang-update branch March 10, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmarkovski tmarkovski Awaiting requested review from tmarkovski

1 more reviewer

@fundthmcalculus fundthmcalculus fundthmcalculus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022 Q1

Development

Successfully merging this pull request may close these issues.

Proposed Golang SDK Updates

4 participants

@sethjback @fundthmcalculus @tmarkovski