More go and python fixes #483
Conversation
| } | ||
|
|
||
| options.Channel = conn | ||
| conn, err := NewServiceConnection(options.ServiceOptions) |
There was a problem hiding this comment.
We've made the base class private so that access to the channel property is no longer accessible. Are we not allowing developers to provide a grpc connection for re-use?
There was a problem hiding this comment.
We removed the channel as direct dependency from service construction to simplify what we pass, but channel is still available for reuse.
There was a problem hiding this comment.
Sounds good - the way the WithChannel option was handled was to use the channel if provided, and if not we would create a default one.
I understand there could be some confusion if a developer provided both a grpc connection and a "connection config", since we use the provided connection and ignore the config. That being said, I would think a developer who needed to provide a custom grpc connection would not be confused when that was used (the expected behaviour) vs. the config they provided (if they did).
My confusion was just around removing the WithChannel option - since the base implementations are now private channel reuse in golang is no longer possible (you can get the channel, but you cannot provide that to another service when constructing it).
No description provided.