Skip to content

Conversation

@shubhamjha25
Copy link
Contributor

As per the things mentioned in #183, I have updated the CONTRIBUTING.md file.
Added a detailed workflow of the steps to contribute to this open-source project.

Fixes #183

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Attaching 1 screenshot for reference.
PR SC

With a detailed workflow of the steps to contribute
@shubhamjha25
Copy link
Contributor Author

@DenverCoder1, Do let me know your review.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! Great explanation.

I just have a few very minor suggestions.

@shubhamjha25
Copy link
Contributor Author

Did the necessary changes as per your suggestion.
Have a look!

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a couple things that weren't changed yet

CONTRIBUTING.md Outdated

### Need some help regarding the basics?

You can refer to the following articles on basics of Git and Github in case you are stuck:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can refer to the following articles on basics of Git and Github in case you are stuck:
You can refer to the following articles on the basics of Git and GitHub in case you are stuck:

CONTRIBUTING.md Outdated
Comment on lines 153 to 154
# This message get associated with all files you have changed
git commit -m "message"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This message get associated with all files you have changed
git commit -m "message"
# This message will get associated with all files you have changed
git commit -m "message"

CONTRIBUTING.md Outdated
Comment on lines 172 to 178
- Go to your forked repository in your browser and click on "Compare and pull requests". Then add a title and description to your pull request that explains your contribution.

<img width="700" alt="compare and pull request" src="https://user-images.githubusercontent.com/63443481/136186304-c0a767ea-1fd2-4b0c-b5a8-3e366ddc06a3.PNG">

<img width="882" alt="opening pull request" src="https://user-images.githubusercontent.com/63443481/136186322-bfd5f333-136a-4d2f-8891-e8f97c379ba8.PNG">

- Voila! Your Pull Request has been submitted and it's ready to be merged.🥳 <br />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Go to your forked repository in your browser and click on "Compare and pull requests". Then add a title and description to your pull request that explains your contribution.
<img width="700" alt="compare and pull request" src="https://user-images.githubusercontent.com/63443481/136186304-c0a767ea-1fd2-4b0c-b5a8-3e366ddc06a3.PNG">
<img width="882" alt="opening pull request" src="https://user-images.githubusercontent.com/63443481/136186322-bfd5f333-136a-4d2f-8891-e8f97c379ba8.PNG">
- Voila! Your Pull Request has been submitted and it's ready to be merged.🥳 <br />
- Go to your forked repository in your browser and click on "Compare and pull request". Then add a title and description to your pull request that explains your contribution.
<img width="700" alt="compare and pull request" src="https://user-images.githubusercontent.com/63443481/136186304-c0a767ea-1fd2-4b0c-b5a8-3e366ddc06a3.PNG">
<img width="882" alt="opening pull request" src="https://user-images.githubusercontent.com/63443481/136186322-bfd5f333-136a-4d2f-8891-e8f97c379ba8.PNG">
- Voila! Your Pull Request has been submitted and it's ready to be merged. 🥳

CONTRIBUTING.md Outdated

### Step 1 : Fork the Project

- Fork this repository. This will create a copy of this repository on your Github profile.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fork this repository. This will create a copy of this repository on your Github profile.
- Fork this repository. This will create a copy of this repository on your GitHub profile.

@shubhamjha25
Copy link
Contributor Author

Done.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for contributing! 🎉

@DenverCoder1 DenverCoder1 merged commit 6ed28c7 into DenverCoder1:main Oct 6, 2021
@Tucamote13
Copy link

Coded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve The Contribution Guidelines Documentation

3 participants