Add notification concept and reference docs#18
Merged
Conversation
Signed-off-by: nscuro <nscuro@protonmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class documentation for the notifications concept and a reference for notification groups, and wires both into the docs navigation/cross-links.
Changes:
- Introduces a new “About notifications” concepts page describing alerts, publishers, templates, levels, scopes, groups, and triggers.
- Adds a new reference page enumerating notification groups (with scope/trigger/level) and links to it from filter expression docs and reference nav.
- Updates concepts navigation labels (“About …”) and fixes an incorrect “alerts” link in the notifications design doc.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/reference/notifications/groups.md | New reference page listing notification groups and their metadata. |
| docs/reference/notifications/filter-expressions.md | Adds cross-link to notification groups. |
| docs/reference/notifications/.pages | Adds “Groups” entry to notifications reference nav. |
| docs/concepts/vulnerability-policies.md | Renames H1 to “About vulnerability policies”. |
| docs/concepts/notifications.md | New concepts page explaining the notification framework. |
| docs/concepts/architecture/design/notifications.md | Fixes “alerts” link to point to the concepts page. |
| docs/concepts/access-control.md | Renames H1 to “About access control”. |
| docs/concepts/.pages | Updates nav labels and adds “About notifications”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.