Merged
Conversation
It turns out that creating a draft release doesn't trigger a `release: created` event. Instead, we need to push a tag, which then fires the `push: tags` event. For this to work, the push must be performed with a non-default PAT. A BOT_RELEASE_GITHUB_TOKEN secrets has been created with minimal privileges, and scoped to this repository. Note that tags were previously created implicitly when creating the GitHub release. Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
Updates the release/publish GitHub Actions workflows so that publishing is triggered by pushing a version tag (instead of relying on a release: created event), and ensures the tag push is performed with a non-default bot PAT.
Changes:
- Update the publish workflow trigger from
release: createdtopushon version tags. - Adjust the release workflow to create a version tag via
npm version(novprefix), push the tag, and useBOT_RELEASE_GITHUB_TOKENfor authenticated operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci-release.yaml | Uses bot PAT for checkout + GitHub release creation; ensures npm version produces a numeric tag and pushes it. |
| .github/workflows/ci-publish.yaml | Switches publish trigger to push events for numeric tags to align with tag-based release flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes release workflow.
It turns out that creating a draft release doesn't trigger a
release: createdevent. Instead, we need to push a tag, which then fires thepush: tagsevent.For this to work, the push must be performed with a non-default PAT. A BOT_RELEASE_GITHUB_TOKEN secrets has been created with minimal privileges, and scoped to this repository.
Note that tags were previously created implicitly when creating the GitHub release.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly