Fix license creation toast message#1520
Open
C2015 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1417.
This updates the add-license modal so a successfully created license shows the license-specific success toast instead of reusing the project creation message.
The change also adds the new
license_createdi18n key across the existing locale files.Testing
npx eslint src/views/portfolio/licenses/LicenseAddLicenseModal.vue --report-unused-disable-directivesnode -e "const fs=require('fs'); for (const f of fs.readdirSync('src/i18n/locales')) { const p='src/i18n/locales/'+f; const data=JSON.parse(fs.readFileSync(p,'utf8')); if (!data.message?.license_created) throw new Error(f+' missing license_created'); } console.log('all locale files contain message.license_created');"npm run buildNote:
npm run vue-i18n-extractcurrently fails before reporting missing/unused keys withEISDIR: illegal operation on a directory, readinvue-i18n-extract. Full-reponpm run eslintalso fails on pre-existing repository-wide lint issues unrelated to this change.