fix(tools): fix inaccuracies in MCP tool descriptions#36
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the descriptions and parameter schemas for several workspace and app member tools to reflect updated permission requirements, deprecations, and tool references. Specifically, it clarifies that workspace API keys are accepted, notes that inviting users by username is deprecated in favor of email addresses, and corrects references to other tools. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Tool description strings are read verbatim by the LLM agent, so errors can affect agent behavior, not just human-facing docs. - remove_app_shared_team: drop "owner team cannot be detached (403)" clause copy-pasted from remove_app_team; the owner team is a project-level regular team and is never attached as a workspace shared team, so the clause is unreachable for this shared-team-only tool. - add_project_member: fix cross-reference add_member -> add_team_member (the atomic single-team add), matching remove_project_member which points to remove_team_member. - create_project / add_workspace_member / remove_workspace_member / update_saml_certificate: describe the required permission instead of asserting "USER API token"; the /api/enterprises/** endpoints also accept a workspace API key (which bypasses the user-ability checks). - add_workspace_member: note role="guest" is partner-only, and document user as an email address (username invites are deprecated). - list_app_members: frame Group-owned apps (users + teams) as the current-plan case and user-owned apps (users + usage) as legacy. Fixes #34 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
299f613 to
3016178
Compare
Summary
Fixes inaccuracies in MCP tool description strings in
src/tools/*.ts, found while documenting the tools on docs.deploygate.com. Since these descriptions are read verbatim by the LLM agent, the errors can affect agent behavior — not just human-facing docs.Fixes #34.
Changes
A. Incorrect (fixed)
remove_app_shared_team(app-members.ts): drop the "The owner team cannot be detached (403)" clause copy-pasted fromremove_app_team. The owner team is a project-level regular team and is never attached to an app as a workspace shared team, so the clause is unreachable for this shared-team-only tool.add_project_member(workspace-projects.ts): fix the cross-referenceadd_member→add_team_member(the atomic single-team add). This also restores symmetry withremove_project_member, which already points toremove_team_member.create_project/add_workspace_member/remove_workspace_member/update_saml_certificate: stop asserting "USER API token". The/api/enterprises/**endpoints also accept a workspace API key (which bypasses the user-ability/admin checks; project/group API keys are rejected). Descriptions now state the required permission and note a workspace API key is also accepted.B. Missing constraints (added)
add_workspace_member: noterole="guest"is available only to certain partner workspaces.add_workspace_member: documentuseras an email address (inviting an existing user by username is deprecated).C. Clarity (optional)
list_app_members: frame Group-owned apps (users + teams) as the current-plan case and legacy user-owned apps (users + usage quota) as legacy.enterpriseis the API name.Testing
npm run build— passesnpm test— 381/381 pass🤖 Generated with Claude Code