Skip to content

fix(tools): fix inaccuracies in MCP tool descriptions#36

Merged
tnj merged 2 commits into
mainfrom
fix/tool-description-inaccuracies
Jun 3, 2026
Merged

fix(tools): fix inaccuracies in MCP tool descriptions#36
tnj merged 2 commits into
mainfrom
fix/tool-description-inaccuracies

Conversation

@tnj
Copy link
Copy Markdown
Member

@tnj tnj commented Jun 3, 2026

Summary

Fixes inaccuracies in MCP tool description strings in src/tools/*.ts, found while documenting the tools on docs.deploygate.com. Since these descriptions are read verbatim by the LLM agent, the errors can affect agent behavior — not just human-facing docs.

Fixes #34.

Changes

A. Incorrect (fixed)

  • remove_app_shared_team (app-members.ts): drop the "The owner team cannot be detached (403)" clause copy-pasted from remove_app_team. The owner team is a project-level regular team and is never attached to an app as a workspace shared team, so the clause is unreachable for this shared-team-only tool.
  • add_project_member (workspace-projects.ts): fix the cross-reference add_memberadd_team_member (the atomic single-team add). This also restores symmetry with remove_project_member, which already points to remove_team_member.
  • create_project / add_workspace_member / remove_workspace_member / update_saml_certificate: stop asserting "USER API token". The /api/enterprises/** endpoints also accept a workspace API key (which bypasses the user-ability/admin checks; project/group API keys are rejected). Descriptions now state the required permission and note a workspace API key is also accepted.

B. Missing constraints (added)

  • add_workspace_member: note role="guest" is available only to certain partner workspaces.
  • add_workspace_member: document user as an email address (inviting an existing user by username is deprecated).

C. Clarity (optional)

  • list_app_members: frame Group-owned apps (users + teams) as the current-plan case and legacy user-owned apps (users + usage quota) as legacy.
  • C-2 ("Enterprise" wording) left as-is, since enterprise is the API name.

Testing

  • npm run build — passes
  • npm test — 381/381 pass

🤖 Generated with Claude Code


Open in Devin Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the descriptions and parameter schemas for several workspace and app member tools to reflect updated permission requirements, deprecations, and tool references. Specifically, it clarifies that workspace API keys are accepted, notes that inviting users by username is deprecated in favor of email addresses, and corrects references to other tools. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Tool description strings are read verbatim by the LLM agent, so errors
can affect agent behavior, not just human-facing docs.

- remove_app_shared_team: drop "owner team cannot be detached (403)"
  clause copy-pasted from remove_app_team; the owner team is a
  project-level regular team and is never attached as a workspace shared
  team, so the clause is unreachable for this shared-team-only tool.
- add_project_member: fix cross-reference add_member -> add_team_member
  (the atomic single-team add), matching remove_project_member which
  points to remove_team_member.
- create_project / add_workspace_member / remove_workspace_member /
  update_saml_certificate: describe the required permission instead of
  asserting "USER API token"; the /api/enterprises/** endpoints also
  accept a workspace API key (which bypasses the user-ability checks).
- add_workspace_member: note role="guest" is partner-only, and document
  user as an email address (username invites are deprecated).
- list_app_members: frame Group-owned apps (users + teams) as the
  current-plan case and user-owned apps (users + usage) as legacy.

Fixes #34

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@tnj tnj force-pushed the fix/tool-description-inaccuracies branch from 299f613 to 3016178 Compare June 3, 2026 02:30
@tnj tnj changed the title docs(tools): fix inaccuracies in MCP tool descriptions fix(tools): fix inaccuracies in MCP tool descriptions Jun 3, 2026
@tnj tnj merged commit 50a33a4 into main Jun 3, 2026
4 checks passed
@tnj tnj deleted the fix/tool-description-inaccuracies branch June 3, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inaccuracies in MCP tool descriptions (workspace auth, shared-team copy-paste, add_project_member cross-ref, guest role, invite-by-email)

1 participant