Skip to content

Conversation

@jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Mar 15, 2024

Tweaked a few testcase to use bit flags instead of the constant value.

@jmatsu jmatsu marked this pull request as ready for review March 15, 2024 08:48
@jmatsu jmatsu requested a review from satsukies March 15, 2024 08:48
Copy link
Member

@satsukies satsukies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

Truth.assertThat(app.sdkArtifactVersion).isEqualTo("4.6.1");
Truth.assertThat(app.activeFeatureFlags).isEqualTo(31);
Truth.assertThat(app.sdkArtifactVersion).isEqualTo("4.7.0");
Truth.assertThat(app.activeFeatureFlags).isEqualTo(FULL_BIT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good changes because clear to why this value is needed 👍

@jmatsu jmatsu merged commit b5ce875 into master Mar 18, 2024
@jmatsu jmatsu deleted the jmatsu/bump/4.7.0 branch March 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants