Conversation
anoworl
changed the title
jmatsu
suggested changes
Nov 1, 2022
| command ADD_DEVICES do |c| | ||
| c.syntax = 'dg add-devices' | ||
| c.description = I18n.t('command_builder.add_devices.description') | ||
| c.option '--message STRING', String, I18n.t('command_builder.add_devices.message') |
Contributor
There was a problem hiding this comment.
It looks better for me to use command_builder.deploy.message to represent reuse. What do you think? @anoworl
Contributor
Author
There was a problem hiding this comment.
Thank you. True. I will change it.
Contributor
Author
There was a problem hiding this comment.
I did! 21cd279
And I checked "dg add-devices -h" outputs.
| c.option '--distribution-key STRING', String, I18n.t('command_builder.add_devices.distribution_key') | ||
| c.option '--configuration STRING', String, I18n.t('command_builder.deploy.configuration') | ||
| c.option '--server', I18n.t('command_builder.add_devices.server.description') | ||
| c.option '--disable_notify', I18n.t('command_builder.add_devices.disable_notify') |
…e_notify_and_message_options_in_add_devices
anoworl
commented
Nov 1, 2022
Contributor
Author
anoworl
left a comment
anoworl
left a comment
There was a problem hiding this comment.
Thank you! I reflected and replied the reviews.
jmatsu
approved these changes
Nov 1, 2022
| c.description = I18n.t('command_builder.add_devices.description') | ||
| c.option '--user STRING', String, I18n.t('command_builder.add_devices.user') | ||
| c.option '--message STRING', String, I18n.t('command_builder.deploy.message') | ||
| c.option '--user STRING', String, I18n.t('command_builder.deploy.user') |
Contributor
Author
|
Thank you! |
anoworl
deleted the
work/support_disable_notify_and_message_options_in_add_devices
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to dg deploy command, I supported disable_notify and message options in dg add-devices command.
Checklist