Compatibility with Gradle 7.0 #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
reviewed
Apr 13, 2021
Contributor
jmatsu
left a comment
jmatsu
left a comment
There was a problem hiding this comment.
Good catch! When did the error happen by the way? I think we can cover the case through GradleCompatAcceptanceSpec by adding Gradle 7.0 to the seeds if it's when applying the plugin or running any task (i.e. evaluation at the runtime),
|
|
||
| CountDownLatch latch | ||
| @Internal CountDownLatch latch | ||
| boolean saved |
Contributor
There was a problem hiding this comment.
Don't we need Internal here?
Contributor
Author
There was a problem hiding this comment.
We have a private getter method below so Gradle considers save is @Internal 👍 (If we have @Internal for save with the private getter method, Gradle complains the redundant annotation).
| [System.getenv(DeployGatePlugin.ENV_NAME_API_TOKEN)].any() | ||
| } | ||
|
|
||
| // From Gradle 7.0, only one method to get boolean property value is allowed |
Contributor
Author
|
The error raised when executing |
jmatsu
approved these changes
Apr 13, 2021
|
|
||
| CountDownLatch latch | ||
| @Internal CountDownLatch latch | ||
| boolean saved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Gradle 7.0, we need to explicitly annotate the properties with
@Input,@Outputor@Internal. Also only one getter method is allowed for a property whereas Groovy generates 2 getters (isXXX()andgetXXX()) for boolean property.This pull request adds annotations (
LoginTaskandUploadArtifactTaskproperties are not for inputs or outputs so I annotated with@Internal) and suppress generatinggetXXX()for boolean property by havingisXXX()method explicitly.see also: