Don't send the value of the visibility property and make it deprecated #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
reviewed
May 10, 2022
src/main/groovy/com/deploygate/gradle/plugins/dsl/syntax/DeploymentSyntax.groovy
Show resolved
Hide resolved
Contributor
Contributor
|
I'll take over this task. |
jmatsu
changed the title
Contributor
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jmatsu wrote down this contents instead:
It's no longer required to send the
visibilityparameter to the server but we should allow users to set/get the visibility property to avoid breaking changes in API. This PR marked them as deprecated and printed warnings if called.