Builds would fail if api token is found but app owner name is not found #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/groovy/com/deploygate/gradle/plugins/tasks/LoginTaskSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/com/deploygate/gradle/plugins/tasks/LoginTaskSpec.groovy
Show resolved
Hide resolved
…pec.groovy Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…pec.groovy Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/test/groovy/com/deploygate/gradle/plugins/tasks/LoginTaskSpec.groovy
Outdated
Show resolved
Hide resolved
Merged
satsukies
approved these changes
Mar 17, 2023
| return; | ||
| } | ||
|
|
||
| if (!credentials.getAppOwnerName().isPresent() && credentials.getApiToken().isPresent()) { |
Contributor
Author
|
Thank you so much~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #171
Don't allow a situation that an app owner name is not available but an api token is provided.
This includes a bug fix related to a response file.