use new style find python#146
Merged
constantinpape merged 6 commits intoDerThorsten:masterfrom Oct 17, 2024
Merged
Conversation
Will test at conda-forge in a moment
1 task
Contributor
Author
|
You might also just want to delete: https://github.com/hmaarrfk/nifty/blob/patch-1/conda-recipe/build.sh.old |
Contributor
Author
|
Hmm FindVigra and likely most other things from: https://github.com/hmaarrfk/nifty/tree/patch-1/cmake/modules should just be removed. sorry for that noise feel free to force push to revert anything here. |
constantinpape
approved these changes
Sep 4, 2024
Collaborator
|
Thanks @hmaarrfk. It looks like the CI is outdated. I will fix this in a separate PR. |
Contributor
Author
|
great to see this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://cmake.org/cmake/help/latest/module/FindPython.html for more info
and the results of
conda-forge/nifty-feedstock#19