Fix some compiler warnings in the 2dlib directory#643
Merged
Lgt2x merged 9 commits intoDescentDevelopers:mainfrom Dec 1, 2024
Merged
Fix some compiler warnings in the 2dlib directory#643Lgt2x merged 9 commits intoDescentDevelopers:mainfrom
Lgt2x merged 9 commits intoDescentDevelopers:mainfrom
Conversation
Lgt2x
reviewed
Nov 26, 2024
This removes some unused variables in 2dlib/pen.cpp.
This fixes an integer signedness compiler warning and cleans up the grViewport::draw_text_line method in 2dlib/pentext.cpp.
This fixes an unused variable compiler warning in Release builds in 2dlib/memsurf.cpp.
This fixes a set but not used compiler warning in Release builds in 2dlib/font.cpp.
Lgt2x
approved these changes
Dec 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
These patches fix some compiler warnings in the 2dlib directory.
Most are unused variables or integer signedness missmatch warnings.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments