Skip to content

Conversation

@avishaan24
Copy link
Contributor

Note

  • We strictly follow the Contribution Guideline and expect contributors to follow it as well.
  • If a lot of conflicts/changes are requested in the PR, please open a new PR with the requested changes (either you or we can close the PR).

Have you read the Contribution Guidelines? If not, check CONTRIBUTING.md file first.

Yes

Description

I made button in the format which is given to me.

Class Naming Convention for your button

  • Does your html button element have class-name like this: your_github_username-button-index (example: rajkumar-justcoder-button-1 ).

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.

mark [X] to make it checked.

Related Issues

Fixes Issue # (write number after #)

Screenshot

Screenshot (4)

@netlify
Copy link

netlify bot commented Oct 22, 2022

Deploy Preview for css-buttons-hover ready!

Name Link
🔨 Latest commit a1c74e4
🔍 Latest deploy log https://app.netlify.com/sites/css-buttons-hover/deploys/63565f7354ccfe00088af84e
😎 Deploy Preview https://deploy-preview-131--css-buttons-hover.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rajkumar-justcoder
Copy link
Member

As per contributing guide all things are prefect except one thing that keyframes should follow same way we make classes for button ( point no 8 )

@Rajkumar-justcoder
Copy link
Member

but as of now all thing is fine i have changed it so take care while making other pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants