Skip to content

Conversation

@Abhishek-dab
Copy link
Member

Note

  • We strictly follow the Contribution Guideline and expect contributors to follow it as well.
  • If a lot of conflicts/changes are requested in the PR, please open a new PR with the requested changes (either you or we can close the PR).

Have you read the Contribution Guidelines? If not, check CONTRIBUTING.md file first.

Yes

Description

Added a new CSS button

Class Naming Convention for your button

  • Does your html button element have class-name like this: your_github_username-button-index (example: rajkumar-justcoder-button-1 ).

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.

mark [X] to make it checked.

Related Issues

Fixes Issue #144 (write number after #)

Screenshot

image

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for css-buttons-hover ready!

Name Link
🔨 Latest commit 65ee680
🔍 Latest deploy log https://app.netlify.com/sites/css-buttons-hover/deploys/635b946929c05c00098b2cfb
😎 Deploy Preview https://deploy-preview-145--css-buttons-hover.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Abhishek-dab Abhishek-dab closed this by deleting the head repository Oct 28, 2022
@Abhishek-dab Abhishek-dab reopened this Oct 28, 2022
@Abhishek-dab
Copy link
Member Author

Hi @Rajkumar-justcoder , can you pls check the PR and merge it.
Thanks.

Comment on lines +2601 to +2602
.abhishek0-btn-1 {
background-color: initial;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change your classes names to as i said it should be your github-username not name so githubusername-btn-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pls be creative this is just simple change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants