feat: Add page-level filtering for icons and images#54
Merged
alexey1312 merged 4 commits intomainfrom Feb 11, 2026
Merged
Conversation
alexey1312
changed the title
Summary of ChangesHello @alexey1312, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the asset export process by introducing page-level filtering for Figma icons and images. Previously, filtering was limited to the frame level, which could lead to incorrect exports when multiple Figma pages contained frames with identical names. The new functionality allows for more precise control over which assets are exported by specifying the Figma page, thereby preventing naming conflicts and improving the reliability of asset generation. This change impacts configuration, CLI usage, and the core loading logic, ensuring a robust and flexible filtering mechanism. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Enhance configurations to allow filtering by Figma page names. This change aids in distinguishing components across pages with identical frame names. Updates include: - Introduced `figmaPageName` in both `FrameSource` and platform-specific entries. - Updated relevant loading functions and configurations to acknowledge this filter. - Improved tests to validate various fallback scenarios for `figmaPageName`.
alexey1312
force-pushed
the
alexey1312/add-page-fillter
branch
from
8206c7c to
ddfaba5
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces page-level filtering for icons and images by adding a figmaPageName field. The changes are extensive and well-executed, touching configuration schemas, data loaders, CLI commands, and documentation. The new feature is consistently threaded through all layers of the application, and the accompanying tests are thorough, covering the new logic and fallback behaviors. I've identified a couple of minor maintainability improvements in the test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional
figmaPageNamefield to enable page-level filtering for icons and images. Previously, filtering was limited tofile → frame, which caused incorrect exports when multiple Figma pages contained identically-named frames. Filtering now supportsfile → page → framewith a 3-tier fallback: entry → common → nil.figmaPageNameto PKLFrameSource,Common.Icons, andCommon.ImagesschemaspageNametoIconsSourceInput,ImagesSourceInput,IconsLoaderConfig,ImagesLoaderConfigImageLoaderBase.fetchImageComponents()filter to checkcontainingFrame.pageNamepageNamethrough all loading methods (8 methods in ImageLoaderBase, IconsLoader, ImagesLoader)figmaPageNameto source inputs--page/-pCLI option to download commandsfigmaPageNameexamples to init template configsfigmaPageNamedocumentation