Improve CI/CD workflows (and support merge queues)#56
Merged
HappyPaul55 merged 2 commits intomainfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the CI/CD workflows to enhance automation and support merge queues.
- Introduces new sub workflows for release, build, and deploy.
- Adds dedicated workflows for main branch merges and feature branch builds/deployments, while removing legacy branch build configurations.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/subworkflow-release.yml | Adds a release workflow to publish to the App Marketplace. |
| .github/workflows/subworkflow-deploy.yml | Introduces a deploy workflow for the demo environment. |
| .github/workflows/subworkflow-build.yml | Implements a build workflow covering lint, test, build, and tag processes. |
| .github/workflows/pr_build.yml | Removed in favor of consolidated workflows. |
| .github/workflows/main_merge.yml | Configures main branch builds with tagging and subsequent release. |
| .github/workflows/feature_build.yml | Provides build and deploy steps for feature branches and merge queues. |
| .github/workflows/branch_build.yml | Deprecated branch build workflow removed. |
| id: package | ||
| working-directory: app-package | ||
| run: | | ||
| packageFilename=`jq -r .name manifest.json | iconv -t ascii//TRANSLIT | sed -r s/[~\^]+//g | sed -r s/[^a-zA-Z0-9]+/-/g | sed -r s/^-+\|-+$//g | tr A-Z a-z` |
There was a problem hiding this comment.
[nitpick] Consider quoting the sed expressions (for example: sed -r "s/^-+|-+$//g") to enhance readability and avoid potential issues with word splitting.
Suggested change
| packageFilename=`jq -r .name manifest.json | iconv -t ascii//TRANSLIT | sed -r s/[~\^]+//g | sed -r s/[^a-zA-Z0-9]+/-/g | sed -r s/^-+\|-+$//g | tr A-Z a-z` | |
| packageFilename=`jq -r .name manifest.json | iconv -t ascii//TRANSLIT | sed -r "s/[~\^]+//g" | sed -r "s/[^a-zA-Z0-9]+/-/g" | sed -r "s/^-+|-+$//g" | tr A-Z a-z` |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Build for commit 8b0649a deployed to: https://copper-pr-56.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.