Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds Sentry integration for enhanced error tracking by configuring the Vite plugin, initializing Sentry at runtime, and adjusting the CI workflow.
- Injects
@sentry/vite-plugininto the Vite build and enables source maps - Initializes Sentry in a new
instrument.tsmodule based on URL parameters - Supplies Sentry credentials in CI and conditionally disables Sentry during non-tagged builds
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added sentryVitePlugin under plugins and misplaced sourcemap in server block |
| src/main.tsx | Imported Sentry and the new instrumentation module |
| src/instrument.ts | Created runtime Sentry initialization from URL params |
| package.json | Added dependencies @sentry/react and @sentry/vite-plugin |
| .github/workflows/subworkflow-build.yml | Injected Sentry secrets and added logic to set SENTRY_DISABLED |
Comments suppressed due to low confidence (1)
src/instrument.ts:7
- [nitpick] There are no tests verifying that Sentry is initialized only when
_sentry_dsnis present. Consider adding unit or integration tests to cover both paths (with and without DSN) to prevent regressions.
if (sentryDsn) {
…e-error-reporting-for-apps-sentry
|
Build for commit 5b3b0a5 deployed to: https://gitlab-pr-68.ci.next.deskprodemo.com URLs: |
tidbit1
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error reporting for apps by integrating Sentry. It includes the necessary configurations and updates to the main.tsx file to handle errors effectively.