Skip to content

chore(sc-65330): Improve error reporting for apps by reporting to Sentry#68

Merged
AFOJ merged 12 commits intomainfrom
chore/sc-65330/improve-error-reporting-for-apps-sentry
Jun 20, 2025
Merged

chore(sc-65330): Improve error reporting for apps by reporting to Sentry#68
AFOJ merged 12 commits intomainfrom
chore/sc-65330/improve-error-reporting-for-apps-sentry

Conversation

@HappyPaul55
Copy link
Contributor

This PR improves error reporting for apps by integrating Sentry. It includes the necessary configurations and updates to the main.tsx file to handle errors effectively.

Copilot AI review requested due to automatic review settings May 28, 2025 11:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Sentry integration for enhanced error tracking by configuring the Vite plugin, initializing Sentry at runtime, and adjusting the CI workflow.

  • Injects @sentry/vite-plugin into the Vite build and enables source maps
  • Initializes Sentry in a new instrument.ts module based on URL parameters
  • Supplies Sentry credentials in CI and conditionally disables Sentry during non-tagged builds

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vite.config.ts Added sentryVitePlugin under plugins and misplaced sourcemap in server block
src/main.tsx Imported Sentry and the new instrumentation module
src/instrument.ts Created runtime Sentry initialization from URL params
package.json Added dependencies @sentry/react and @sentry/vite-plugin
.github/workflows/subworkflow-build.yml Injected Sentry secrets and added logic to set SENTRY_DISABLED
Comments suppressed due to low confidence (1)

src/instrument.ts:7

  • [nitpick] There are no tests verifying that Sentry is initialized only when _sentry_dsn is present. Consider adding unit or integration tests to cover both paths (with and without DSN) to prevent regressions.
if (sentryDsn) {

@github-actions
Copy link

@AFOJ AFOJ merged commit 0375f70 into main Jun 20, 2025
5 checks passed
@AFOJ AFOJ deleted the chore/sc-65330/improve-error-reporting-for-apps-sentry branch June 20, 2025 16:00
@AFOJ AFOJ mentioned this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants