Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Sentry for enhanced error reporting by adding build-time plugins, runtime initialization, and CI configuration updates.
- Adds the Sentry Vite plugin and sourcemap support in
vite.config.ts - Initializes Sentry at runtime via a new
instrument.tsscript and imports it inmain.tsx - Updates CI workflow to inject Sentry secrets and disable reporting on non-tag builds
- Adds Sentry packages and removes the
react-error-boundarydependency
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Configure sentryVitePlugin conditionally and enable sourcemaps |
| src/main.tsx | Import Sentry and the instrumentation script |
| src/instrument.ts | Initialize Sentry based on URL parameters |
| package.json | Add @sentry/react and @sentry/vite-plugin; remove error boundary dep |
| .github/workflows/subworkflow-build.yml | Pass Sentry env vars to CI and adjust build logic |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
package.json:28
- The
react-error-boundarydependency was removed but no replacement boundary is implemented; verify that any existing error boundary logic is replaced to prevent runtime issues.
"react-error-boundary": "^4.1.2",
src/main.tsx:1
- [nitpick] Consider wrapping the
<App />component in aSentry.ErrorBoundaryor providing a custom fallback UI to ensure UI errors are properly captured and communicated.
import * as Sentry from '@sentry/react';
|
Build for commit 8cc4629 deployed to: https://mondaycom-pr-41.ci.next.deskprodemo.com URLs: |
AFOJ
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error reporting for apps by integrating Sentry. It includes the necessary configurations and updates to the main.tsx file to handle errors effectively.