Improve CI/CD workflows (and support merge queues)#45
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines and consolidates the CI/CD workflows while introducing support for merge queues. Key changes include the addition of new workflows for release, deployment, build, main branch merges, and feature builds, as well as the removal of deprecated workflows.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/subworkflow-release.yml | Introduces a release workflow to deploy packages to the Marketplace. |
| .github/workflows/subworkflow-deploy.yml | Adds a deployment workflow for PR demo environments with SSH context. |
| .github/workflows/subworkflow-build.yml | Implements a build workflow that lints, tests, builds, and tags the code. |
| .github/workflows/main_merge.yml | Creates a main branch build workflow coordinating build and release. |
| .github/workflows/feature_build.yml | New feature build workflow with merge queue support. |
| .github/workflows/pr_build.yml and branch_build.yml | Deprecated workflows removed in favor of consolidated flows. |
| id: package | ||
| working-directory: app-package | ||
| run: | | ||
| packageFilename=`jq -r .name manifest.json | iconv -t ascii//TRANSLIT | sed -r s/[~\^]+//g | sed -r s/[^a-zA-Z0-9]+/-/g | sed -r s/^-+\|-+$//g | tr A-Z a-z` |
There was a problem hiding this comment.
[nitpick] Consider using the $(...) syntax for command substitution instead of backticks for improved readability and consistency.
| https://api.github.com/repos/deskpro/deskpro-product/contents/docker/compose/deskpro-demo/docker-compose.yml | ||
|
|
||
| - name: Create Docker SSH context | ||
| uses: deskpro/gh-actions/create-ssh-docker-context@master |
There was a problem hiding this comment.
Pin the version of the 'create-ssh-docker-context' action instead of referencing the 'master' branch to ensure stability.
|
|
||
| - name: Deploy demo | ||
| id: deployment | ||
| uses: deskpro/gh-actions/deploy-deskpro-demo@master |
There was a problem hiding this comment.
Pin the version of the 'deploy-deskpro-demo' action instead of using the 'master' branch to avoid potential instability.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Build for commit f3d9b2e deployed to: https://toggl-pr-45.ci.next.deskprodemo.com URLs: |
1 participant
No description provided.