Force item amounts to update in the UI when modified#1685
Merged
bhollis merged 1 commit intoDestinyItemManager:devfrom May 28, 2017
Merged
Force item amounts to update in the UI when modified#1685bhollis merged 1 commit intoDestinyItemManager:devfrom
bhollis merged 1 commit intoDestinyItemManager:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a consequence of my recent bind-once efficiency hacks, updating the amount of stackables as they were moved around broke (#1676). The fix is awkward, but involves making Angular see a completely new object (by cloning and replacing the item) with a new index (by regenerating the index, since amount is part of the index) which will cause it to completely replace the directive.
While I was there I also restricted the source/target items to only be in the same bucket as the item you're moving. Won't change anything, but it'll inspect fewer items.