cbm_find_cli() fails on Windows: wrong PATH delimiter and S_IXUSR check

[slvnlrt]

Bug

cbm_find_cli() never finds OpenCode or Aider on Windows because:

1. It uses : as PATH delimiter — Windows uses ;. This splits C:\Users\... at the drive letter colon, producing garbage paths.
2. S_IXUSR check always fails — stat() on Windows does not set Unix permission bits. npm installs CLI shims as extensionless files (e.g. opencode, not opencode.exe), which stat() finds but the S_IXUSR check rejects.

This was noted in commit 5ca369f3 which skips OpenCode/Aider in Windows smoke tests rather than fixing detection.

Reproduction

# Install opencode
npm install -g opencode-ai

# Verify it's on PATH
where.exe opencode
# C:\Users\<user>\AppData\Roaming\npm\opencode
# C:\Users\<user>\AppData\Roaming\npm\opencode.cmd

# Run install
codebase-memory-mcp install -y
# Detected agents: Claude-Code Gemini-CLI Zed Antigravity
# (OpenCode is missing)

Root cause

In src/cli/cli.c, cbm_find_cli():

char *dir = strtok_r(path_copy, ":", &saveptr);
// ...
if (stat(buf, &st) == 0 && (st.st_mode & S_IXUSR)) {

1. : delimiter splits C:\Users\... at the drive letter colon → garbage paths
2. S_IXUSR is a Unix concept — stat() on Windows never sets this bit

Suggested fix

#ifdef _WIN32
const char *path_sep = ";";
#else
const char *path_sep = ":";
#endif
char *dir = strtok_r(path_copy, path_sep, &saveptr);
// ...
#ifdef _WIN32
if (stat(buf, &st) == 0) {           // file exists is enough
#else
if (stat(buf, &st) == 0 && (st.st_mode & S_IXUSR)) {
#endif

Environment

• Windows 11 Pro
• codebase-memory-mcp 0.5.7
• OpenCode installed via npm (opencode-ai)

[slvnlrt]

Update: the initial analysis was incomplete. The .exe extension probing was a red herring.

npm installs CLI tools as extensionless shims (e.g. opencode, not opencode.exe). The real blockers are:

1. PATH delimiter: : splits C:\Users\... at the drive letter colon → garbage paths. Fix: use ; on Windows.
2. S_IXUSR check: stat() on Windows does not set Unix permission bits, so the executable check always fails even when the file exists. Fix: just check stat() == 0 on Windows.

PR #161 has been updated accordingly.

[DeusData]

Hey @slvnlrt, could you ask your coding agent to commit in a PR tests which reproduce this errors? This would be the easiest way for me to fix this :)

[slvnlrt]

Hey! The tests are actually already in PR #161 :)

Your existing cli_find_cli_on_path and cli_find_cli_fallback_paths tests were guarded with SKIP("PATH search differs on Windows") and SKIP("shell scripts + chmod not available on Windows"), meaning they were known to fail on Windows. My commit re-enables them by:

• Removing the SKIP guards
• Skipping chmod on Windows (not needed when S_IXUSR check is removed)
• Using a Windows-compatible PATH value in the fallback test
• Relaxing the path assertion to handle / vs \ differences

If you run just the test changes on the current code (without the fix), both tests will fail on Windows (reproducing both issues).

A precision on S_IXUSR: the Windows CRT does set it for .exe/.cmd/.bat files, but not for extensionless files. npm shims are extensionless (opencode, not opencode.exe), which is why the check fails. The fix is two small #ifdef _WIN32 blocks (~6 lines of logic).