fix(jvm): resolve mixed Java/Kotlin callgraph edges#684
Open
nguyentamdat wants to merge 1 commit into
Open
Conversation
nguyentamdat
force-pushed
the
java-kotlin-callgraph
branch
from
fb96853 to
e6f8c2a
Compare
Before: Java/Kotlin cross-file LSP emitted package-shaped JVM names while graph nodes stayed path-derived, and member calls like receiver.method did not consume LSP overrides. After: Java and Kotlin share package-indexed JVM defs across mixed Gradle/Maven source roots, normalize JVM defs to declared packages for LSP registries, consume qualified member-call overrides by leaf name, and assert both Java-to-Kotlin and Kotlin-to-Java lsp CALLS edges. Why: /home/dat/ica/server mixes src/main/java and src/main/kotlin in the same JVM packages; path-prefix filtering missed same-package defs and fallback suffix matching produced weaker or wrong call edges. Verify: make -f Makefile.cbm test -> 5705 passed. Signed-off-by: nguyentamdat <nguyentamdat@gmail.com>
nguyentamdat
force-pushed
the
java-kotlin-callgraph
branch
from
e6f8c2a to
f33f068
Compare
Owner
|
Huge thanks for opening this PR and for the work you put into it. The maintainer shop is currently full, so this may sit for a bit before it gets a proper review. We will come back to this as soon as possible with real feedback; I wanted to make sure it did not sit unacknowledged in the meantime. |
DeusData
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/main/java,src/main/kotlin,src/test/java, andsrc/test/kotlinroots for Java/Kotlin fileslsp_idxpathstrategy: lspedges for Java -> Kotlin and Kotlin -> Java callsVerification
make -f Makefile.cbm test->5726 passedNotes
Split out from the original bundled branch so this PR now contains only the JVM callgraph fix. The low-RAM indexing change is now separate in #685.