fix(graph-ui): remove misleading 'Project name' field from index picker#805
fix(graph-ui): remove misleading 'Project name' field from index picker#805rarepops wants to merge 1 commit into
Conversation
|
Personally I would love this to stay and be properly implemented... I should be able to rename projects since I am not a fan of the default names they get now |
|
Heads-up: the |
563f707 to
069fce4
Compare
The optional 'Project name' input was labelled 'Optional display name', but its value became the project's permanent identity (the <name>.db filename, projects.name primary key, and the project. prefix on every node's qualified_name) - not a cosmetic label. Since a project cannot be renamed after indexing and the name is always derivable from the folder path, the field was misleading. Remove the input, its state, and its submit payload; project names now always derive from the selected folder path. Drop the now-dead i18n strings and update the test. Signed-off-by: Zadak <rarepops@protonmail.com>
069fce4 to
c99269b
Compare
|
Thank you for the clean split and the rigorous rationale — and for the patience while we weighed it. Decision: we're keeping the field but fixing the dishonesty you identified, rather than removing it. You're completely right that 'Optional display name' silently becoming permanent, un-renameable identity is a footgun; but removing the field costs the only human-friendly naming affordance in the UI, and the derived fallback names are the full flattened absolute path — rough in every dropdown and query scope. So the field stays with an honest label ('Project ID — permanent, cannot be renamed later') and matching help text, which lands shortly crediting you as co-author for driving the UX analysis. If a project-rename feature ships later, we'll revisit true cosmetic naming. Closing this PR per that decision — your #739 navigation work merges separately as soon as its rebase lands. Thanks again! |
Split out from #739 at the maintainer's request, so this cross-platform change can be discussed as a standalone product / API-shape decision rather than riding along with the Windows navigation work.
What
Removes the optional Project name input from the index picker. Project names now always derive from the selected folder path.
Why
The field was labelled "Optional display name", but its value became the project's permanent identity, not a cosmetic label:
<name>.dbfilename,projects.nameprimary key,project.prefix on every node'squalified_name.Since a project cannot be renamed after indexing and the name is always derivable from the folder path, the field was misleading.
Scope
projectName/projectNamePlaceholderi18n strings (EN + ZH).The backend still accepts the
project_namealias (#640), so this only removes the UI affordance; the request/response shape is unchanged. Happy to discuss whether the field should stay, be relabelled, or be removed as done here.