Fix build error with libgit2 -Wmissing-field-initializers#91
Open
jsyrjala wants to merge 1 commit intoDeusData:mainfrom
Open
Fix build error with libgit2 -Wmissing-field-initializers#91jsyrjala wants to merge 1 commit intoDeusData:mainfrom
jsyrjala wants to merge 1 commit intoDeusData:mainfrom
Conversation
Build fails at pass_githistory.c:171 with:
error: missing field 'interhunk_lines' initializer
[-Werror,-Wmissing-field-initializers]
git_diff_options diff_opts = GIT_DIFF_OPTIONS_INIT;
codebase-memory-mcp at 75b5dcb has this issue. The GIT_DIFF_OPTIONS_INIT
macro does not list all struct fields, which clang flags as an error
under -Werror.
Replace the macro with the runtime git_diff_options_init() API, which
properly initializes all fields. Available since libgit2 0.28.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pass_githistory.c:171with-Werror,-Wmissing-field-initializersbecauseGIT_DIFF_OPTIONS_INITmacro doesn't list all struct fieldsgit_diff_options_init()runtime API, which properly initializes all fieldsgit_diff_options_init()available since libgit2 0.28 (2019)Test plan
scripts/build.shcompletes without errorsFixes #104
🤖 Generated with Claude Code