fix(event): replace organizerId with organizer public fields in GET /:slug#346
Open
anshul23102 wants to merge 1 commit into
Open
fix(event): replace organizerId with organizer public fields in GET /:slug#346anshul23102 wants to merge 1 commit into
anshul23102 wants to merge 1 commit into
Conversation
…:slug response The event detail endpoint was returning the raw organizer UUID via organizerId, leaking an internal database identifier to unauthenticated callers. Fetch the organizer relation and expose organizerUsername and organizerDisplayName instead.
Contributor
Author
|
@Neit6138 could you please add the relevant labels to this PR? It would help with tracking. Thank you! |
Harxhit
added
the
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #330
GET /events/:slugendpoint was returningorganizerId(a raw internal database UUID) in the response, leaking a private identifier to any caller including unauthenticated ones.organizerrelation join to the Prisma query (select: { username, displayName }).organizerId: stringin theEventDetailsresponse type withorganizerUsername: stringandorganizerDisplayName: string.Changes
apps/backend/src/routes/event.ts: updatedEventDetailstype, PrismafindUniqueinclude, and response object mapping.Test plan
GET /events/:slugfor an existing event returnsorganizerUsernameandorganizerDisplayNameinstead oforganizerId.GET /events/:slugfor a non-existent slug still returns404.tsc --noEmit).