Skip to content

fix: remove unauthenticated public upload access#350

Merged
ShantKhatri merged 1 commit into
Dev-Card:mainfrom
Midoriya-w:fix/protect-upload-access
May 27, 2026
Merged

fix: remove unauthenticated public upload access#350
ShantKhatri merged 1 commit into
Dev-Card:mainfrom
Midoriya-w:fix/protect-upload-access

Conversation

@Midoriya-w
Copy link
Copy Markdown
Contributor

@Midoriya-w Midoriya-w commented May 26, 2026

Summary

Removed public static serving for /uploads/ to prevent unauthenticated access to uploaded files.

Previously, uploaded files could be accessed directly without authentication or ownership validation.

Closes #334

Type of Change

  • Bug fix
  • Security fix

Changes Made

  • Removed public fastifyStatic registration for uploads
  • Prevented direct public access to uploaded files
  • Added security comments documenting expected authenticated access flow

@Harxhit Harxhit added the gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. label May 27, 2026
@ShantKhatri ShantKhatri merged commit 6a1c6a2 into Dev-Card:main May 27, 2026
1 check failed
@Harxhit Harxhit added level:advanced Complex contribution involving deeper technical work. (+55 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:performance Performance optimization (+15 pts) type:security Security-related fixes/improvements (+20 pts) type:refactor Code refactoring/cleanup (+10 pts) labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved Required label for every approved PR. Gives the base +50 points and enables contribution tracking. level:advanced Complex contribution involving deeper technical work. (+55 pts) quality:clean PR is well-structured, readable, and follows good practices. (×1.2 multiplier) type:performance Performance optimization (+15 pts) type:refactor Code refactoring/cleanup (+10 pts) type:security Security-related fixes/improvements (+20 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Static uploads served without authentication any file accessible without login

3 participants