test(connect): add regression testing for oauth callback flow#411
Open
VIDYANKSHINI wants to merge 1 commit into
Open
test(connect): add regression testing for oauth callback flow#411VIDYANKSHINI wants to merge 1 commit into
VIDYANKSHINI wants to merge 1 commit into
Conversation
Collaborator
|
@VIDYANKSHINI Please add tests terminal proof in PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive regression testing for the OAuth connect callback flow to fulfill the Acceptance Criteria for Issue #380. (Note: The core route logic to remove
app.authenticateand use the Redis nonce flow was already merged in upstreammainduring a previous sync, so this PR exclusively adds the missing test coverage to guarantee its security and functionality).Closes #380
Type of Change
What Changed
apps/backend/src/__tests__/connect.test.ts:vitest,mockRedis, andmockPrisma.codeorstate).redis.delis strictly called upon nonce verification.How to Test
apps/backenddirectory.pnpm exec vitest run src/__tests__/connect.test.ts.Checklist
pnpm -r run lintpasses).pnpm -r run typecheck).pnpm -r run test).console.logor debug statements left in the code.Screenshots / Recordings
N/A (Tests only)
Additional Context
The mocked test environment utilizes Fastify
app.injectrequests to simulate browser-level GET redirects. It correctly verifies that the Redis layer mitigates CSRF while keeping the endpoints gracefully redirecting to/settingswith specific error query parameters.