Build multi-arch docker image #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 I wonder if you would accept this pull request to build the docker image on both
linux/arm64andlinux/amd64? I've tested these workflows on my fork, they behave the same on merge (tagging withbranch-short_sha) and pushing a tag (tagging with the version) as they do today, and I confirmed that I can start containers on both architectures from the built image.The changes look more extensive than they are, to make this work there is a bit more setup and a switch to the
docker/build-push-actionaction, which supports buildx+qemu.