feat(menu): 菜单组件 #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kagol merged 7 commits into DevCloudFE:dev from GaoNeng-wWw:gaonengwWw/menu

Apr 19, 2022

Collaborator

GaoNeng-wWw commented Apr 18, 2022

No description provided.

GaoNeng-wWw added 3 commits

April 18, 2022 16:59


          feat(menu): 菜单组件

6fcb230


          feat(menu): menu组件

9eaaf0c


          fix(theme): 恢复误删除变量

0bc9a67

pr-triage bot added the PR: unreviewed label

kagol reviewed

View reviewed changes

packages/devui-vue/devui/menu/index.ts Outdated Show resolved Hide resolved

kagol reviewed

View reviewed changes

packages/devui-vue/devui/menu/index.ts Show resolved Hide resolved

kagol reviewed

View reviewed changes

packages/devui-vue/devui/menu/src/components/menu-item.tsx Show resolved Hide resolved

kagol reviewed

View reviewed changes

packages/devui-vue/devui/menu/src/styles/clear.scss Outdated Show resolved Hide resolved

kagol reviewed

View reviewed changes

packages/devui-vue/devui/menu/src/menu.scss Outdated Show resolved Hide resolved

Member

kagol commented Apr 18, 2022

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：

pnpm build

Member

kagol commented Apr 18, 2022

命名上有两个需要优化的点：

hooks改成composables，保持一致性
实际hooks的命名使用use开头，比如useMenu

Collaborator Author

GaoNeng-wWw commented Apr 18, 2022

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：
pnpm build

本地运行pnpm build后报ReferenceError: location is not defined错误

Member

kagol commented Apr 18, 2022 •

edited

Loading

构建任务失败了，建议本地执行以下命令，看下构建失败的原因：
pnpm build
本地运行pnpm build后报ReferenceError: location is not defined错误

你看下这个构建日志的信息哈~
https://github.com/DevCloudFE/vue-devui/runs/6060814179?check_suite_focus=true

我看报错信息是这个：

Could not resolve '../types/menu-item-type' from devui/menu/src/components/menu-item.tsx

GaoNeng-wWw and others added 3 commits

April 18, 2022 20:40


          Merge branch 'DevCloudFE:dev' into gaonengwWw/menu

0d3d346


          fix(menu): pr#516

91f9724


          fix(menu): 修复类型文件丢失

2d7d561

GaoNeng-wWw closed this

GaoNeng-wWw reopened this


          fix(menu): 修复了一个逻辑错误

db1c9c7

kagol added the feature label

kagol approved these changes

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels

kagol merged commit c4f281e into DevCloudFE:dev

pr-triage bot added PR: merged and removed PR: reviewed-approved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PR: merged