Skip to content

display option now blocks all prints in optimization module#71

Merged
lenarddome merged 1 commit intoDevComPsy:mainfrom
tzukpolinsky:main
Oct 16, 2025
Merged

display option now blocks all prints in optimization module#71
lenarddome merged 1 commit intoDevComPsy:mainfrom
tzukpolinsky:main

Conversation

@tzukpolinsky
Copy link
Copy Markdown
Contributor

Hi
i started working with your repo, and the print "Starting optimization ..." really fill my screen so i forked you repo and apply the display argument to manage this print as well

Tzuk

@lenarddome lenarddome self-requested a review October 15, 2025 07:44
@lenarddome lenarddome added the enhancement New feature or request label Oct 15, 2025
@lenarddome lenarddome assigned lenarddome and unassigned lenarddome Oct 15, 2025
@lenarddome
Copy link
Copy Markdown
Collaborator

Thanks for the PR, it is a neat addition! Can you also write some corresponding test units to cover this? It’ll make sure we don’t break it in future updates. 😊

@tzukpolinsky
Copy link
Copy Markdown
Contributor Author

hmmmm a unit test for the output on the screen?
i can be it feels a bit much:)

let me know

@lenarddome
Copy link
Copy Markdown
Collaborator

If you feel that it is a bit too much, that is completely fine. I will rerun some simulation code to see how it works and take it from there.

The reason I was asking is that as we go along, and implement different optimisation procedures, we will want to see different degrees of output on the screen depending on our goals. We also have plans to enable the output of different details for debugging purposes. Creating a test unit for this now can facilitate the continuation of the current edit.

@tzukpolinsky
Copy link
Copy Markdown
Contributor Author

absolutely right, for now its only boolean. if you will need help with something more sophisticate let me know:)

@lenarddome lenarddome merged commit 4204095 into DevComPsy:main Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants