Skip to content

switch to use Timber logging and support log level adjustment#23

Merged
squarepegg merged 3 commits intomainfrom
DVC-1873-log-level
Jan 13, 2022
Merged

switch to use Timber logging and support log level adjustment#23
squarepegg merged 3 commits intomainfrom
DVC-1873-log-level

Conversation

@ajwootto
Copy link
Copy Markdown
Contributor

@ajwootto ajwootto commented Jan 6, 2022 •
edited
Loading

  • add support for adjustable log levels using Timber library
  • allow disabling logging entire by passing -1 as the level
  • default log level to ERROR

jsalaber
jsalaber requested changes Jan 7, 2022
View reviewed changes
Comment thread android-client-sdk/src/main/java/com/devcycle/sdk/android/api/DVCClient.kt Outdated
@squarepegg squarepegg requested a review from jsalaber January 13, 2022 03:49
@squarepegg squarepegg merged commit 7fa924d into main Jan 13, 2022
@squarepegg squarepegg deleted the DVC-1873-log-level branch January 13, 2022 17:16
@jonathannorris jonathannorris mentioned this pull request Apr 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathannorris jonathannorris jonathannorris approved these changes

@jsalaber jsalaber jsalaber approved these changes

+1 more reviewer

@squarepegg squarepegg squarepegg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajwootto @jonathannorris @squarepegg @jsalaber