Prompt for variation values when updating feature variables#254
Merged
emmawillis merged 1 commit intomainfrom Aug 11, 2023
Merged
Prompt for variation values when updating feature variables#254emmawillis merged 1 commit intomainfrom
emmawillis merged 1 commit intomainfrom
Conversation
25c24e9 to
da06985
Compare
2186f4b to
e9ecedc
Compare
e9ecedc to
8282bd6
Compare
nsalamad
approved these changes
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this is a little bit sketchy because when updating the variables list, we need to essentially update the feature variations list as a semi-related side effect. Because the functions on VariableListOptions have to return a valid list option, i couldn't figure out a cleaner way to update the feature variations than to store them on the VariableListOptions class and access them in the feature update command separately. if there's a better way let me know!!
New prompts when editing a variable within a feature update:

this prompt won't show up when updating a single variable outside of a feature, or if you select variables and variations from the chooseFields prompt (since the variations prompt will already ask for the variable values).