Skip to content

Ruby SDK Updates#176

Merged
VicV merged 2 commits intomainfrom
dvc-5482
Feb 23, 2023
Merged

Ruby SDK Updates#176
VicV merged 2 commits intomainfrom
dvc-5482

Conversation

@JamieSinn
Copy link
Copy Markdown
Member

No description provided.

@JamieSinn JamieSinn requested review from VicV and nsalamad February 23, 2023 20:11
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
devcycle-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 8:21PM (UTC)

Comment thread docs/sdk/server-side-sdks/ruby.md Outdated
config.api_key['bearerAuth'] = '<DVC_SERVER_SDK_KEY>'
end
options = DevCycle::DVCOptions.new(enable_cloud_bucketing: false, event_flush_interval_ms: 1000, config_polling_interval_ms: 1000)
dvc_client = DevCycle::DVCClient.new("dvc_server_token_hash", options, true)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt we just change all of these to sdk key or something

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdkKey is the parameter name. The string is the example token format.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems weird to call it something different in the example still though :p

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not? That's the parameter value.
I can prefix the value with the param name to make it clear if you want.

@VicV
Copy link
Copy Markdown
Contributor

VicV commented Feb 23, 2023

we like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants